Fix label smoothing incompatibility with multi-label classification #40296
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes a RuntimeError when using
label_smoothing_factor > 0with multi-label classification.Previously, users would get a confusing error:
RuntimeError: gather(): Expected dtype int32/int64 for indexThis PR adds a clear validation check in
LabelSmootherthat detects this incompatible combination and raises a helpful error message instead:Changes:
LabelSmoother.__call__()to detect multi-label classificationValueErrorwith actionable solutionTesting:
Fixes #40258
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@zach-huggingface @SunMarc @qgallouedec - trainer related changes