Fix processing tests #40379
Merged
Fix processing tests #40379
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
ydshieh
reviewed
Aug 25, 2025
ydshieh
reviewed
Aug 25, 2025
ydshieh
reviewed
Aug 25, 2025
ydshieh
reviewed
Aug 25, 2025
I will check this afternoon, but I need a bit more context (so my comment above 🙏 ) |
ydshieh
reviewed
Aug 25, 2025
|
|
||
| @property | ||
| def model_input_names(self): | ||
| # InternVL renames video inputs to `pixel_values` before returning |
There was a problem hiding this comment.
nice to have comment.
Might would be even better to explain a bit more:
- does this simply "what we are doing here" (and if so, why?)
- or does this mean because
InternVL renames video inputs topixel_valuesbefore returning, so we need to have this change here (otherwise something would go wrong)
There was a problem hiding this comment.
yeah, that is the reason to override it, will make it clear
|
[For maintainers] Suggested jobs to run (before merge) run-slow: aria, chameleon, deepseek_vl_hybrid, gemma3, glm4v, grounding_dino, hunyuan_v1_moe, internvl, llava, mistral3, mllama, pix2struct, qwen2_vl, smolvlm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
I broke the CI in #40339 🙈 No idea why the tests weren't triggered before merging
The newly added test is failing for InetrnVL, QwenAudio (and others) because the number of video/audio placeholders doesn't match number of actual video/audios. The fix is to allow to prepare dummy text with different modality placeholder, especially useful when a processor can process more than one modality