[modular] Use multi-processing + fix model import issue #40481
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Cyrilvallez
commented
Aug 27, 2025
Comment on lines
-1229
to
+1230
| rf"(?:transformers\.models\.)|(?:\.\.)\w+\.({self.match_patterns})_.*", import_statement | ||
| rf"(?:transformers\.models\.)|(?:\.\.\.models\.)|(?:\.\.)\w+\.({self.match_patterns})_.*", |
There was a problem hiding this comment.
This was missing, which caused from ...models.name.modeling import issues in #40431
qubvel
approved these changes
Aug 27, 2025
There was a problem hiding this comment.
Thanks! Looks good
At some point, we might need to organize a topologically sorted queue with multiple workers if the dependency tree depth grows significantly (keeping the width low, e.g. 1-2). However, this is unlikely to happen if we reuse more modules from older models than the recent ones
|
Looks good, I will rebase it and check any remaining changes once merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
As per the title. Let's use multiprocessing by default on the converter, and it also fixes relative imports of the form
from ...models.name.modeling_ import ...that caused the issue of on-conversion in #40431cc @qubvel as well, only the checker was using mp until now -> high time for the converter to do it as well, as running all conversions locally is starting to take quite some time