KEMBAR78
Improve generation of not equals check by ElektroKill · Pull Request #3425 · icsharpcode/ILSpy · GitHub
Skip to content

Improve generation of not equals check #3425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 22, 2025
Merged

Improve generation of not equals check #3425

merged 2 commits into from
Mar 22, 2025

Conversation

@ElektroKill
Copy link
Contributor

Link to issue(s) this covers:
fixes #3423

Problem

The decompiler would use 0 for the != 0 check even if the type was an enum.

Solution

  • Adjust the code to use ExpressionBuilder.ConvertConstantValue to generate the expression for the 0 constant
  • A pretty test was added to cover the issue

ElektroKill
ElektroKill commented Mar 18, 2025
View reviewed changes
@siegfriedpammer
Copy link
Member

Thank you very much for your contribution!

@siegfriedpammer siegfriedpammer merged commit 4ef3581 into icsharpcode:master Mar 22, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@siegfriedpammer siegfriedpammer siegfriedpammer approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Enum fails to resolve in != 0 condition

2 participants

@ElektroKill @siegfriedpammer