Fix changes due to eval order fix #3440
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dgrunwald I was able to fix most of the problems. However, there are a few test cases still failing because of weird codegen with redundant assignments such as |
This was
linked to
issues
Mar 29, 2025
siegfriedpammer
force-pushed
the
bugfix/constrained-call-targets
branch
from
75b3321 to
aa7fa1a
Compare
…f evaluation with regards to the implicit ldobj performed by a constrained.callvirt.
siegfriedpammer
force-pushed
the
bugfix/constrained-call-targets
branch
2 times, most recently
from
00e9197 to
d987828
Compare
siegfriedpammer
force-pushed
the
bugfix/constrained-call-targets
branch
from
d987828 to
6c72d1c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason: Recent changes in the runtime as well as Roslyn fixing an eval order bug of constrained calls.
Link to issue(s) this covers
#3438
#3419
I will clean up the PR before merge.