KEMBAR78
Some clarifications about window.rAF() by Manishearth · Pull Request #1033 · immersive-web/webxr · GitHub
Skip to content

Some clarifications about window.rAF() #1033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 11, 2020
Merged

Some clarifications about window.rAF() #1033

merged 2 commits into from
May 11, 2020

Conversation

Manishearth
Copy link
Contributor

@Manishearth Manishearth commented May 11, 2020 •
edited by pr-preview bot
Loading

Fixes #736, fixes #225

Preview | Diff

@Manishearth Manishearth requested a review from toji May 11, 2020 22:20
@Manishearth Manishearth changed the title Add non-normative note about warning about session.rAF() called within window.rAF() Some clarifications about window.rAF() May 11, 2020
toji
toji approved these changes May 11, 2020
View reviewed changes
Copy link
Member

@toji toji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Manishearth Manishearth merged commit 3e66a5d into immersive-web:master May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@toji toji toji approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

2 participants

@Manishearth @toji