KEMBAR78
Added validation for XRRigidTransform by cabanier · Pull Request #1043 · immersive-web/webxr · GitHub
Skip to content

Added validation for XRRigidTransform #1043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 15, 2020
Merged

Added validation for XRRigidTransform #1043

merged 1 commit into from
May 15, 2020

Conversation

cabanier
Copy link
Member

@cabanier cabanier commented May 15, 2020 •
edited by pr-preview bot
Loading

Closes #1040

Preview | Diff

toji
toji approved these changes May 15, 2020
View reviewed changes
Copy link
Member

@toji toji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @Manishearth?

@Manishearth Manishearth merged commit d3aa05e into immersive-web:master May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@toji toji toji approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Should XRRigidTransform reject non-finite values

3 participants

@cabanier @toji @Manishearth