KEMBAR78
Mention correct input frame semantics on XRInputSource/frame by Manishearth · Pull Request #1053 · immersive-web/webxr · GitHub
Skip to content

Conversation

Manishearth
Copy link
Contributor

@Manishearth Manishearth commented May 20, 2020

getViewerPose() step 3 will raise an InvalidStateError with input frames, so the line about views arrays being empty is meaningless since you can't create XRViewerPoses anyway.

fixes #1054


Preview | Diff

@Manishearth Manishearth requested a review from toji May 20, 2020 17:48
Copy link
Member

@toji toji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Manishearth Manishearth merged commit efa3f25 into immersive-web:master May 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Event frame pose?

2 participants