KEMBAR78
Primary views MUST always be active by Manishearth · Pull Request #1105 · immersive-web/webxr · GitHub
Skip to content

Primary views MUST always be active #1105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 24, 2020
Merged

Primary views MUST always be active #1105

merged 3 commits into from
Jul 24, 2020

Conversation

Manishearth
Copy link
Contributor

@Manishearth Manishearth commented Jul 23, 2020 •
edited by pr-preview bot
Loading

@Manishearth Manishearth requested a review from toji July 23, 2020 21:02
thetuvix
thetuvix reviewed Jul 24, 2020
View reviewed changes
@Manishearth @thetuvix
Update index.bs
8518b9a 
Co-authored-by: Alex Turner <alexturn@microsoft.com>
toji
toji approved these changes Jul 24, 2020
View reviewed changes
Copy link
Member

@toji toji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Manishearth Manishearth merged commit de37208 into immersive-web:master Jul 24, 2020
@Manishearth Manishearth deleted the primary-views-active branch July 24, 2020 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@toji toji toji approved these changes

+1 more reviewer

@thetuvix thetuvix thetuvix left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Restrict adding/removing displays after session starts without "secondary-views"

3 participants

@Manishearth @toji @thetuvix