KEMBAR78
Clarify that framebuffer scale factors apply to width/height separately by klausw · Pull Request #1131 · immersive-web/webxr · GitHub
Skip to content

Clarify that framebuffer scale factors apply to width/height separately #1131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 25, 2020
Merged

Clarify that framebuffer scale factors apply to width/height separately #1131

merged 1 commit into from
Sep 25, 2020

Conversation

klausw
Copy link
Contributor

@klausw klausw commented Sep 23, 2020 •
edited by pr-preview bot
Loading

This clarification was requested as part of the dynamic viewport scaling discussion, see #1091 (comment) .

Preview | Diff

toji
toji approved these changes Sep 23, 2020
View reviewed changes
Copy link
Member

@toji toji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for this important clarification!

@Manishearth Manishearth merged commit 72c9858 into immersive-web:master Sep 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@toji toji toji approved these changes

@Manishearth Manishearth Manishearth approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@klausw @toji @Manishearth