Restructures input-explainer.md to improve clarity and prep for hit-testing proposal #492
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or hit-testing proposal
NellWaliczek
force-pushed
the
input-explainer-cleanup
branch
from
64c4ce5 to
15a0899
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on the proposal for adding hit testing to WebXR, it became clear that to easily explain the new hit testing concepts, the input explainer needed a bit of house keeping. I ended up moving a large portion of the document content around, so it may be easier to just view the new version of the document rather than the diff.
The intent with this PR is to clarify the descriptions of existing functionality, not to introduce changes in that functionality. That said, I expect we may uncover shared misunderstandings through the cleaner text, so please do call out things that don't match your expectations. I also removed the grab-and-drag sample code for the moment; it makes a reappearance in the hit-testing-explainer in PR #493
For ease of diffing, the base for this PR is adding-viewerSpace branch behind PR #491