KEMBAR78
Spec XRPresentationContext creation by Manishearth · Pull Request #501 · immersive-web/webxr · GitHub
Skip to content

Conversation

@Manishearth
Copy link
Contributor

fixes #449

r? @toji

Copy link
Member

@NellWaliczek NellWaliczek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@toji
Copy link
Member

toji commented Feb 5, 2019

LGTM as well, but unfortunately there's some conflicts with a PR I merged yesterday. If you have an opportunity to resolve them, @Manishearth, please do. Otherwise I'll see if I can take a moment to do the resolve myself in the next day or so.

@Manishearth Manishearth force-pushed the xrpresentationcontext branch from b54972f to 3cbb64f Compare February 6, 2019 09:09
@Manishearth
Copy link
Contributor Author

Rebased!

@toji toji merged commit dc04205 into immersive-web:master Feb 6, 2019
@toji
Copy link
Member

toji commented Feb 6, 2019

Awesome, thanks!

@Manishearth Manishearth deleted the xrpresentationcontext branch August 13, 2019 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

XRPresentationContext should be a dictionary

3 participants