KEMBAR78
Describe exceptions that updateRenderState may throw. by toji · Pull Request #511 · immersive-web/webxr · GitHub
Skip to content

Describe exceptions that updateRenderState may throw. #511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 6, 2019
Merged

Describe exceptions that updateRenderState may throw. #511

merged 1 commit into from
Feb 6, 2019

Conversation

@toji
Copy link
Member

@toji toji commented Feb 6, 2019

Based on some observations made while attempting to implement updateRenderState in Chrome.

@toji toji requested a review from NellWaliczek February 6, 2019 21:42
NellWaliczek
NellWaliczek approved these changes Feb 6, 2019
View reviewed changes
Copy link
Member

@NellWaliczek NellWaliczek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@toji toji merged commit 1001de4 into master Feb 6, 2019
@toji toji deleted the renderstate-exceptions branch May 2, 2019 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@NellWaliczek NellWaliczek NellWaliczek approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@toji @NellWaliczek