KEMBAR78
Forbid using stale XRViews in getViewport() by Manishearth · Pull Request #796 · immersive-web/webxr · GitHub
Skip to content

Forbid using stale XRViews in getViewport() #796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 13, 2019
Merged

Forbid using stale XRViews in getViewport() #796

merged 2 commits into from
Aug 13, 2019

Conversation

Manishearth
Copy link
Contributor

@Manishearth Manishearth mentioned this pull request Aug 13, 2019
Closed
toji
toji requested changes Aug 13, 2019
View reviewed changes
Copy link
Member

@toji toji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really close! But we need one change before it's good to go.

@toji
Copy link
Member

toji commented Aug 13, 2019

You, sir, are absurdly fast at responding to feedback! 😮 Thanks!

@toji toji merged commit eca36e4 into immersive-web:master Aug 13, 2019
@toji toji added this to the August 2019 milestone Aug 13, 2019
@Manishearth Manishearth deleted the getviewport-stale branch August 13, 2019 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@toji toji toji requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

August 2019

Development

Successfully merging this pull request may close these issues.

Should getViewport return null if there is no matching viewport?

2 participants

@Manishearth @toji