KEMBAR78
Defining when an opaque framebuffer is considered dirty by toji · Pull Request #970 · immersive-web/webxr · GitHub
Skip to content

Conversation

toji
Copy link
Member

@toji toji commented Mar 4, 2020

This cribs very directly from the equivalent WebGL spec text, with appropriate verbiage changes. Related to #969, but doesn't actually fix that one since the issue itself is more about what happens when the users doesn't dirty the framebuffer for a while.

Copy link
Member

@cabanier cabanier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "...but only if..." section of the sentence is a bit hard to read but otherwise this looks good to me

@toji
Copy link
Member Author

toji commented Mar 4, 2020

Just realized that this /fixes #877

Copy link
Contributor

@Manishearth Manishearth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r? @asajeffrey as well

@asajeffrey
Copy link

LGTM FWIW

@toji toji merged commit 9d3ccaf into master Mar 5, 2020
@toji toji deleted the dirty-buffer branch March 5, 2020 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants