KEMBAR78
Repurposes repository for development of the WebXR Gamepads Module by NellWaliczek · Pull Request #1 · immersive-web/webxr-gamepads-module · GitHub
Skip to content

Repurposes repository for development of the WebXR Gamepads Module #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 9, 2019
Merged

Repurposes repository for development of the WebXR Gamepads Module #1

merged 4 commits into from
Aug 9, 2019

Conversation

@NellWaliczek
Copy link
Member

@NellWaliczek NellWaliczek commented Jul 30, 2019 •
edited
Loading

This repo was cloned from the original WebXR repo, and this PR removes a bunch of text and images unrelated to Gamepads in WebXR. This includes:

  • Removing and altering the text in the index.bs file
  • Removing explainer.md, hit-testing-explainer.md, spatial-tracking-explainer.md and associated images
  • Removing generic input related text from the input-explainer.md which is now the gamepad-module-explainer.md
  • Removing all the design docs
  • Updating the README.md

@NellWaliczek NellWaliczek requested a review from toji July 30, 2019 00:27
toji
toji reviewed Jul 30, 2019
View reviewed changes
toji
toji approved these changes Jul 30, 2019
View reviewed changes
Copy link
Member

@toji toji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now! Thanks!

@NellWaliczek NellWaliczek changed the title Removes all files and references to non-gamepads related stuff Repurposes repository for development of the WebXR Gamepads Module Jul 30, 2019
@NellWaliczek NellWaliczek marked this pull request as ready for review July 30, 2019 17:15
@NellWaliczek NellWaliczek mentioned this pull request Jul 30, 2019
Merged
@NellWaliczek NellWaliczek merged commit eaa3cdd into master Aug 9, 2019
@NellWaliczek
Copy link
Member Author

This PR has approval, has been open for over a week, and no additional feedback or discussion is underway here or on the email list. It is now merged so we can move forward with FPWD and wide review.

@NellWaliczek NellWaliczek deleted the gamepads-only branch September 20, 2019 03:15
@toji toji mentioned this pull request Jul 18, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@toji toji toji approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@NellWaliczek @toji