#1234 Protoype Access in :: Operator #1590
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ccess node before any additional property accesses
…oncat into Value#add; removed unnecessary INDEX_PROTO
|
Here's a full diff of the entire patch (since the diff in Commits <> only shows the changes between the last two commits). |
|
Nice to see progress :] I wonder, why do you gist a diff and not commit to a fork? |
|
@Dykam I will if that makes life easier for the |
|
I see all 3 commits and a combined diff. No idea what you guys are talking about. |
|
The diff didn't get on the mail, so I looked over it, never mind. |
test/operators.coffee
Outdated
There was a problem hiding this comment.
To be a little less confusing:
class C
method: -> @nonce
nonce: nonce
arr = []
eq nonce, C::method arr... # should be applied to `C::`
There was a problem hiding this comment.
Yes -- that looks better. I'll update in a moment :)
|
Awesome patch, @geraldalewis. LGTM. |
|
Thanks to you @michaelficarra :) |
|
Gorgeous patch. |
jashkenas
added a commit
that referenced
this pull request
Aug 12, 2011
#1234 Protoype Access in :: Operator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #1234: Applying a splat to a prototype using :: applies the splat to the wrong object
Opened by: @Dykam
Date opened: March 25, 2011
Milestone: 1.2
Thanks to @michaelficarra for pointing to a solution and review!
Dykam's illustrative code:
Solution: Adding an intermediary
prototypeAccessnode between the class and the method within the grammar.I have some questions regarding some possible refinements posted in the
src/commit.This issue ties into a larger issue on how
::is handled ( with respect to@) -- I will open a new issue that addresses the super-issue within two days.