Fix CI for Node 16.14.x (#5404)

STRd6 · GeoffreyBooth · web-flow · commit 3ad26de8f03f · 2022-04-02T16:53:05.000-07:00
Co-authored-by: Geoffrey Booth &lt;webadmin@geoffreybooth.com&gt;
diff --git a/docs/v2/test.html b/docs/v2/test.html
@@ -25716,22 +25716,31 @@ <h1>CoffeeScript Test Suite</h1>
 <script type="text/x-coffeescript" class="test" id="import_assertions">
 # This file is running in CommonJS (in Node) or as a classic Script (in the browser tests) so it can use import() within an async function, but not at the top level; and we can’t use static import.
 test "dynamic import assertion", ->
-  { default: secret } = await import('data:application/json,{"ofLife":42}', { assert: { type: 'json' } })
-  eq secret.ofLife, 42
+  try
+    { default: secret } = await import('data:application/json,{"ofLife":42}', { assert: { type: 'json' } })
+    eq secret.ofLife, 42
+  catch exception
+    # This parses on Node 16.14.x but throws an error because JSON modules aren’t unflagged there yet; remove this try/catch once the unflagging of `--experimental-json-modules` is backported (see https://github.com/nodejs/node/pull/41736#issuecomment-1086738670)
+    unless exception.message is 'Invalid module "data:application/json,{"ofLife":42}" has an unsupported MIME type "application/json"'
+      throw exception
 
 test "assert keyword", ->
   assert = 1
 
-  { default: assert } = await import('data:application/json,{"thatIAm":42}', { assert: { type: 'json' } })
-  eq assert.thatIAm, 42
+  try
+    { default: assert } = await import('data:application/json,{"thatIAm":42}', { assert: { type: 'json' } })
+    eq assert.thatIAm, 42
+  catch exception
+    # This parses on Node 16.14.x but throws an error because JSON modules aren’t unflagged there yet; remove this try/catch once the unflagging of `--experimental-json-modules` is backported (see https://github.com/nodejs/node/pull/41736#issuecomment-1086738670)
+    unless exception.message is 'Invalid module "data:application/json,{"thatIAm":42}" has an unsupported MIME type "application/json"'
+      throw exception
 
   eqJS """
     import assert from 'regression-test'
   """, """
     import assert from 'regression-test';
   """
 
-
 test "static import assertion", ->
   eqJS """
     import 'data:application/json,{"foo":3}' assert { type: 'json' }
diff --git a/package-lock.json b/package-lock.json
diff --git a/test/import_assertions.coffee b/test/import_assertions.coffee
@@ -1,21 +1,30 @@
 # This file is running in CommonJS (in Node) or as a classic Script (in the browser tests) so it can use import() within an async function, but not at the top level; and we can’t use static import.
 test "dynamic import assertion", ->
-  { default: secret } = await import('data:application/json,{"ofLife":42}', { assert: { type: 'json' } })
-  eq secret.ofLife, 42
+  try
+    { default: secret } = await import('data:application/json,{"ofLife":42}', { assert: { type: 'json' } })
+    eq secret.ofLife, 42
+  catch exception
+    # This parses on Node 16.14.x but throws an error because JSON modules aren’t unflagged there yet; remove this try/catch once the unflagging of `--experimental-json-modules` is backported (see https://github.com/nodejs/node/pull/41736#issuecomment-1086738670)
+    unless exception.message is 'Invalid module "data:application/json,{"ofLife":42}" has an unsupported MIME type "application/json"'
+      throw exception
 
 test "assert keyword", ->
   assert = 1
 
-  { default: assert } = await import('data:application/json,{"thatIAm":42}', { assert: { type: 'json' } })
-  eq assert.thatIAm, 42
+  try
+    { default: assert } = await import('data:application/json,{"thatIAm":42}', { assert: { type: 'json' } })
+    eq assert.thatIAm, 42
+  catch exception
+    # This parses on Node 16.14.x but throws an error because JSON modules aren’t unflagged there yet; remove this try/catch once the unflagging of `--experimental-json-modules` is backported (see https://github.com/nodejs/node/pull/41736#issuecomment-1086738670)
+    unless exception.message is 'Invalid module "data:application/json,{"thatIAm":42}" has an unsupported MIME type "application/json"'
+      throw exception
 
   eqJS """
     import assert from 'regression-test'
   """, """
     import assert from 'regression-test';
   """
 
-
 test "static import assertion", ->
   eqJS """
     import 'data:application/json,{"foo":3}' assert { type: 'json' }
