Fix: comprehension as postfix conditional (#5310)

helixbass · GeoffreyBooth · web-flow · commit 75d376f2eff7 · 2020-03-10T10:29:00.000-07:00
Co-authored-by: Geoffrey Booth &lt;webmaster@geoffreybooth.com&gt;
diff --git a/lib/coffeescript/nodes.js b/lib/coffeescript/nodes.js
diff --git a/src/nodes.coffee b/src/nodes.coffee
@@ -4527,7 +4527,7 @@ exports.Elision = class Elision extends Base
 # it, all other loops can be manufactured. Useful in cases where you need more
 # flexibility or more speed than a comprehension can provide.
 exports.While = class While extends Base
-  constructor: (@condition, {@invert, @guard, @isLoop} = {}) ->
+  constructor: (@condition, {invert: @inverted, @guard, @isLoop} = {}) ->
     super()
 
   children: ['condition', 'guard', 'body']
@@ -4578,7 +4578,7 @@ exports.While = class While extends Base
     answer
 
   processedCondition: ->
-    @processedConditionCache ?= if @invert then @condition.invert() else @condition
+    @processedConditionCache ?= if @inverted then @condition.invert() else @condition
 
   astType: -> 'WhileStatement'
 
@@ -4587,7 +4587,7 @@ exports.While = class While extends Base
       test: @condition.ast o, LEVEL_PAREN
       body: @body.ast o, LEVEL_TOP
       guard: @guard?.ast(o) ? null
-      inverted: !!@invert
+      inverted: !!@inverted
       postfix: !!@postfix
       loop: !!@isLoop
 
diff --git a/test/comprehensions.coffee b/test/comprehensions.coffee
@@ -613,3 +613,8 @@ test "for pattern variables can linebreak/indent", ->
     anotherNonexistentElement
   ] in listOfArrays
   eq a, 2
+
+test "#5309: comprehension as postfix condition", ->
+  doesNotThrowCompileError """
+    throw new Error "DOOM was called with a null element" unless elm? for elm in elms
+  """
