Welcome @amorey!

It looks like this is your first PR to kubernetes/minikube 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/minikube has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

Hi @amorey. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Can one of the admins verify this patch?

@spowelljr @ComradeProgrammer Just checking in! Would it be possible to take a look at this PR soon? I added an addon so most of the diff is from new yaml files.

@amorey thanks for the PR do u mind posting an example of using this addon and what it is for?

/ok-to-test

@medyagh Kubetail is a logging dashboard for Kubernetes that lets you view multiple log streams simultaneously in the same timeline. Once it's installed in a cluster you can access the dashboard website through a service (e.g. minikube service -n kubetail-system kubetail-dashboard).

Here's a screenshot:

Here's a video:
https://www.youtube.com/watch?v=zyML-Pg12vw

Here's a live demo:
https://demo.kubetail.com

And here's the repo:
https://github.com/kubetail-org/kubetail

Let me know if there's something else I can explain! Is there somewhere in particular I should post examples to?

Here are the number of top 10 failed tests in each environments with lowest flake rate.

Besides the following environments also have failed tests:

• Docker_Linux_crio_arm64: 1 failed (gopogh)

• Docker_Cloud_Shell: 3 failed (gopogh)

• Docker_Linux_crio: 1 failed (gopogh)

To see the flake rates of all tests by environment, click here.

Are these test failures expected? Do I need to apply a fix to this PR? I ran the tests locally and got some errors but they're present in the master too:

FAIL	k8s.io/minikube/deploy/minikube	600.195s
FAIL	k8s.io/minikube/test/stress	600.116s

@medyagh I just rebased and am still working on the PR so you can hold off on approving the tests for now.

@medyagh I updated Kubetail to the latest version that includes the ability to search/grep container logs. It's ok to run the tests now. Here's a demo video of the addon: https://youtu.be/Gjx3ug_Q0A8

Let me know what else I need to do to get the PR merged.

@medyagh @spowelljr @ComradeProgrammer Are the tests expected to pass? The logs are hard to parse but it looks like most of the failures are from code unrelated to addons. Let me know what I need to do for this PR to get merged.

sorry for the delay I forgot about this PR, I will take a look after the release

Awesome! Thanks!

Upgraded to latest version of kubetail, rebased and squashed commits

I just rebased and upgraded to the latest version of Kubetail. Here's a quick demo (2 min) to show the addon in action:
https://www.loom.com/share/77842e7d88d2446781d8c08a1303ff2c?sid=1d0b4435-3772-46b1-b1e8-a4db1ffc94ce

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 20345) |
+----------------+----------+---------------------+
| minikube start | 90.3s    | 45.9s               |
| enable ingress | 15.0s    | 15.7s               |
+----------------+----------+---------------------+

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 20345) |
+----------------+----------+---------------------+
| minikube start | 23.5s    | 24.2s               |
| enable ingress | 13.0s    | 13.2s               |
+----------------+----------+---------------------+

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 20345) |
+----------------+----------+---------------------+
| minikube start | 22.9s    | 22.3s               |
| enable ingress | 36.7s    | 34.9s               |
+----------------+----------+---------------------+

thank you @amorey for your patience and your contribution I look forward to see more contributions from you

/lgtm

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: amorey, medyagh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Thanks @medyagh! I've been using minikube every day for a few years now and I love how well it works. I switch between Intel and Apple Silicon multiple times on a daily basis without skipping a beat. You all are doing an amazing job. Looking forward to contributing!