KEMBAR78
redo "minikube profile list" to move the verbose details into a --det… by LJTian · Pull Request #20544 · kubernetes/minikube · GitHub
Skip to content

redo "minikube profile list" to move the verbose details into a --det… #20544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 6, 2025
Merged

redo "minikube profile list" to move the verbose details into a --det… #20544

merged 1 commit into from
Jun 6, 2025

Conversation

@LJTian
Copy link
Contributor

@LJTian LJTian commented Mar 18, 2025 •
edited
Loading

redo "minikube profile list" to move the verbose details into a --detailed flag

Before modification:
[root@localhost minikube]# minikube profile list -o table
image

After modification:
image

Fixes #18520

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 18, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @LJTian. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 18, 2025
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@LJTian
Copy link
Contributor Author

LJTian commented Mar 18, 2025

/cc @medyagh

@k8s-ci-robot k8s-ci-robot requested a review from medyagh March 18, 2025 07:24
@medyagh
Copy link
Member

medyagh commented Mar 18, 2025

thank you @LJTian for the PR, I dont see the difference between detailed version and normal version, what columns are removed in the normal version ?

@LJTian
Copy link
Contributor Author

LJTian commented Mar 19, 2025

谢谢@LJTian对于 PR，我看不出详细版本和普通版本之间的区别，普通版本中删除了哪些列？

I put the port field in the detailed description according to #18520. If there are other fields that need to be put in the detailed description, please let me know so that I can modify it.

@medyagh
Copy link
Member

medyagh commented Mar 19, 2025

@LJTian I see thanks for clarifying it, that sounds good ! we can later decide if we wanna add more Details to the Detailed View, so there be more difference between standard and detailed

@medyagh
Copy link
Member

medyagh commented Mar 19, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 19, 2025
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 20544) |
+----------------+----------+---------------------+
| minikube start | 47.9s    | 48.5s               |
| enable ingress | 15.4s    | 14.6s               |
+----------------+----------+---------------------+

Times for minikube ingress: 14.9s 14.9s 14.4s 14.4s 18.4s
Times for minikube (PR 20544) ingress: 14.9s 14.4s 15.9s 13.4s 14.4s

Times for minikube start: 44.9s 49.1s 45.5s 49.6s 50.4s
Times for minikube (PR 20544) start: 46.8s 45.9s 49.8s 51.0s 48.9s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 20544) |
+----------------+----------+---------------------+
| minikube start | 22.6s    | 21.9s               |
| enable ingress | 12.3s    | 12.3s               |
+----------------+----------+---------------------+

Times for minikube ingress: 12.2s 12.3s 12.2s 12.7s 12.3s
Times for minikube (PR 20544) ingress: 12.2s 12.7s 12.3s 12.2s 12.2s

Times for minikube start: 23.6s 21.5s 23.2s 24.0s 20.6s
Times for minikube (PR 20544) start: 21.0s 23.4s 20.7s 20.2s 24.5s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 20544) |
+----------------+----------+---------------------+
| minikube start | 21.3s    | 20.8s               |
| enable ingress | 38.8s    | 30.7s               |
+----------------+----------+---------------------+

Times for minikube ingress: 38.7s 39.2s 39.2s 39.2s 37.7s
Times for minikube (PR 20544) ingress: 37.7s 22.7s 31.3s 22.7s 39.2s

Times for minikube start: 22.3s 19.2s 19.9s 22.1s 23.0s
Times for minikube (PR 20544) start: 22.7s 19.3s 22.5s 19.4s 19.9s

@minikube-pr-bot
Copy link

Here are the number of top 10 failed tests in each environments with lowest flake rate.

Environment Test Name Flake Rate
Docker_Linux_crio_arm64 (2 failed) TestStartStop/group/newest-cni/serial/VerifyKubernetesImages(gopogh) 0.00% (chart)
Docker_Windows (3 failed) TestErrorSpam/setup(gopogh) Unknown
Docker_Windows (3 failed) TestKicCustomSubnet(gopogh) Unknown
Docker_Windows (3 failed) TestStartStop/group/old-k8s-version/serial/SecondStart(gopogh) Unknown

Besides the following environments also have failed tests:

  • Docker_Cloud_Shell: 3 failed (gopogh)

  • Docker_Linux_containerd_arm64: 1 failed (gopogh)

To see the flake rates of all tests by environment, click here.

@LJTian
Copy link
Contributor Author

LJTian commented Apr 7, 2025

/cc @medyagh Can it be merged?

@LJTian
Copy link
Contributor Author

LJTian commented Apr 28, 2025

/retest

@medyagh
Copy link
Member

medyagh commented Jun 6, 2025

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 6, 2025
@medyagh
Copy link
Member

medyagh commented Jun 6, 2025

thank you @LJTian

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LJTian, medyagh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@medyagh medyagh merged commit 017ef75 into kubernetes:master Jun 6, 2025
33 of 43 checks passed
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 6, 2025
@LJTian LJTian deleted the profile-isDetailed branch June 10, 2025 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ComradeProgrammer ComradeProgrammer Awaiting requested review from ComradeProgrammer

@prezha prezha Awaiting requested review from prezha

@medyagh medyagh Awaiting requested review from medyagh

Assignees

@medyagh medyagh

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

redo "minikube profile list" to move the verbose details into a --detailed flag

5 participants

@LJTian @k8s-ci-robot @minikube-bot @medyagh @minikube-pr-bot