KEMBAR78
add short hand -m for --memory by medyagh · Pull Request #20854 · kubernetes/minikube · GitHub
Skip to content

add short hand -m for --memory #20854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 29, 2025
Merged

add short hand -m for --memory #20854

merged 2 commits into from
May 29, 2025

Conversation

@medyagh
Copy link
Member

@medyagh medyagh commented May 28, 2025 •
edited
Loading

also hides the deperecated flags

before this PR

$ minikube start --help | grep vm-driver
    --vm-driver='':

After this PR

$ mk start --help | grep network-plugin
$ mk start --help | grep vm-driver
$ mk start --help | grep enable-default-cni

also

$ mk start -d vfkit -m 12gb --cpus 6
😄  minikube v1.36.0 on Darwin 15.5 (arm64)
✨  Using the vfkit driver based on user configuration
👍  Starting "minikube" primary control-plane node in "minikube" cluster
🔥  Creating vfkit VM (CPUs=6, Memory=12288MB, Disk=20000MB) ...

closes #20853

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 28, 2025
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 28, 2025
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 28, 2025
@medyagh medyagh changed the title add short hand -m for --memory add short hand -m for --memory May 28, 2025
@medyagh
Copy link
Member Author

medyagh commented May 28, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label May 28, 2025
@medyagh medyagh changed the title add short hand -m for --memory add short hand -m for --memory and hide depreciated flags May 28, 2025
@medyagh medyagh changed the title add short hand -m for --memory and hide depreciated flags add short hand -m for --memory May 28, 2025
@minikube-pr-bot
Copy link

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 20854) |
+----------------+----------+---------------------+
| minikube start | 52.8s    | 51.4s               |
| enable ingress | 14.9s    | 14.9s               |
+----------------+----------+---------------------+

Times for minikube start: 53.0s 52.1s 52.6s 53.5s 52.8s
Times for minikube (PR 20854) start: 52.7s 50.2s 51.4s 49.7s 52.8s

Times for minikube ingress: 15.6s 14.6s 14.6s 14.6s 15.1s
Times for minikube (PR 20854) ingress: 15.6s 15.2s 14.6s 14.6s 14.6s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 20854) |
+----------------+----------+---------------------+
| minikube start | 25.3s    | 24.8s               |
| enable ingress | 13.1s    | 13.1s               |
+----------------+----------+---------------------+

Times for minikube start: 23.2s 23.0s 25.7s 27.2s 27.6s
Times for minikube (PR 20854) start: 25.4s 26.2s 22.3s 25.9s 24.1s

Times for minikube ingress: 13.8s 13.3s 13.3s 12.4s 12.9s
Times for minikube (PR 20854) ingress: 12.9s 13.3s 13.4s 12.3s 13.3s

docker driver with containerd runtime

+-------------------+----------+---------------------+
|      COMMAND      | MINIKUBE | MINIKUBE (PR 20854) |
+-------------------+----------+---------------------+
| minikube start    | 23.0s    | 23.5s               |
| ⚠️  enable ingress | 32.1s    | 39.4s ⚠️             |
+-------------------+----------+---------------------+

Times for minikube start: 22.0s 22.9s 21.0s 22.5s 26.5s
Times for minikube (PR 20854) start: 22.1s 23.4s 23.3s 25.6s 23.1s

Times for minikube ingress: 39.9s 39.9s 23.9s 33.8s 22.9s
Times for minikube (PR 20854) ingress: 39.8s 39.8s 39.8s 38.9s 38.5s

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ComradeProgrammer, medyagh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ComradeProgrammer,medyagh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@medyagh medyagh merged commit f439f0c into kubernetes:master May 29, 2025
32 of 40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ComradeProgrammer ComradeProgrammer ComradeProgrammer approved these changes

@spowelljr spowelljr Awaiting requested review from spowelljr

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

-m shorthand for --memory and hide deperecated flags from help

4 participants

@medyagh @minikube-pr-bot @k8s-ci-robot @ComradeProgrammer