-
Notifications
You must be signed in to change notification settings - Fork 5.1k
addon: improve ingress-dns addon for windows and bump to v0.0.4 #21449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
addon: improve ingress-dns addon for windows and bump to v0.0.4 #21449
Conversation
|
|
|
Welcome @kartikjoshi21! |
|
Hi @kartikjoshi21. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Can one of the admins verify this patch? |
|
Testing performed:
Logs from the run are attached below. |
Updated ingress-dns addon Pod template to align with current deployment requirements: * Added hostPort mapping for UDP 53 * Mounted ConfigMap for configurable DNS settings * Introduced dns-nodata-delay-ms option via ConfigMap - Switched default ingress-dns image reference from gcr.io/k8s-minikube/minikube-ingress-dns to kicbase/minikube-ingress-dns (multi-arch build available on Docker Hub). - Left legacy image mapping in aliyun_mirror.json for backward compatibility, while adding new kicbase mapping. Signed-off-by: Kartik Joshi <karikjoshi21@gmail.com>
06a76d2 to
3af89a4
Compare
|
/ok-to-test |
|
kvm2 driver with docker runtime Times for minikube start: 48.5s 50.7s 47.8s 49.3s 53.2s Times for minikube ingress: 15.8s 15.9s 16.9s 16.8s 17.4s docker driver with docker runtime Times for minikube start: 24.3s 24.3s 28.1s 21.9s 25.9s Times for minikube ingress: 13.2s 18.7s 13.7s 13.7s 14.7s docker driver with containerd runtime Times for minikube start: 24.7s 24.0s 23.3s 22.5s 22.5s Times for minikube ingress: 23.7s 23.6s 23.7s 31.2s 24.2s |
|
/lgtm thank you @kartikjoshi21 |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kartikjoshi21, medyagh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Updated ingress-dns addon Pod template to align with current
deployment requirements:
Switched default ingress-dns image reference from gcr.io/k8s-minikube/minikube-ingress-dns to kicbase/minikube-ingress-dns (multi-arch build available on Docker Hub).
Left legacy image mapping in aliyun_mirror.json for backward compatibility, while adding new kicbase mapping.