OWNERS cleanup (Release Team's version) #2865
Conversation
Removes the following deprecated roles: - build-admins (Release Engineering) - ci-signal-role (Release Team) - bug-triage-role (Release Team) - release-notes-role (Release Team) Also removed are any subdirectory OWNERS files in which the deprecated role was the only entry. Signed-off-by: Stephen Augustus <foo@auggie.dev>
- Prune previous Release Team leads (thanks for your leadership!) - Move v1.35 subteam role members to aliases Signed-off-by: Stephen Augustus <foo@auggie.dev>
Signed-off-by: Stephen Augustus <foo@auggie.dev>
- Append `-approvers` to aliases - Include `-subteam` in aliases referencing subteams - Lexicographic sort for subteam aliases Signed-off-by: Stephen Augustus <foo@auggie.dev>
- Subproject lead only has membership for `-approvers` alias (which already has access to the appropriate directories) - Create `release-team-lead-shadows` alias - Move RT lead shadows to top-level alias Signed-off-by: Stephen Augustus <foo@auggie.dev>
...also deletes the RT Lead handbooks OWNERS file, since it's now superfluous. Signed-off-by: Stephen Augustus <foo@auggie.dev>
Signed-off-by: Stephen Augustus <foo@auggie.dev>
Signed-off-by: Stephen Augustus <foo@auggie.dev>
k8s-ci-robot
added
kind/cleanup
k8s-ci-robot
added
the
size/XL
|
I'm not really sure why the bot made the reviewers selections it did, but: |
Signed-off-by: Stephen Augustus <foo@auggie.dev>
|
Just so that it can be fixed after this PR is merged, this will require updates to the release lead template: (I won't cover it in my updates until this PR is merged) sig-release/.github/ISSUE_TEMPLATE/release-team-lead-progress.md Lines 45 to 51 in da16357 |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, justaugustus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Continuing the convo here: #2864 (comment) |
8 participants
What type of PR is this:
/kind cleanup documentation
What this PR does / why we need it:
This is the first part of our access control review, tracked in #2864.
In this PR, we dramatically simplify the @kubernetes/release-team OWNERS entries to keep things tidy and accelerate reviews in the respective areas.
cc: @kubernetes/sig-release-leads @katcosgrove @drewhagen
Here's a detailed changelog:
Prune deprecated roles & remove associated subdirectory files
Removes the following deprecated roles:
Also removed are any subdirectory OWNERS files in which the deprecated role was the only entry.
Initial update of all top-level Release Team aliases
Offboard Grace as Release Team subproject lead
Refactor Release Team aliases to match the other entries
-approversto aliases-subteamin aliases referencing subteamsSync all Release Team aliases for current cycle
-approversalias(which already has access to the appropriate directories)
release-team-lead-shadowsaliasAdd explicit reviewers for Release Team top-level dirs
...also deletes the RT Lead handbooks OWNERS file, since it's now superfluous.
Add RT Lead Shadows as Release Team top-level dirs reviewers
Prune files from previous releases
Remove RT Lead and add SIG Release leads to top-level reviewers
Signed-off-by: Stephen Augustus foo@auggie.dev
Which issue(s) this PR fixes:
Special notes for your reviewer:
This one would be good to review commit-by-commit, as there are a few spacing and positional changes of entries that may make the combined diff a little difficult to parse.