KEMBAR78
Support correction when creating feedback with token by hinthornw · Pull Request #736 · langchain-ai/langserve · GitHub
Skip to content

Conversation

@hinthornw
Copy link
Contributor

Closes #735

@cla-bot cla-bot bot added the cla-signed label Aug 30, 2024
@hinthornw hinthornw requested a review from eyurtsev August 30, 2024 21:34
@eyurtsev
Copy link
Collaborator

eyurtsev commented Sep 2, 2024

Updated PR to remove all changes except for the bug fix itself. Was failing unit tests due to backwards compatible changes in langchain-core that were causing unit tests to fail (as those were essentially using snapshots)

@eyurtsev eyurtsev changed the title Support correction Support correction when creating feedback with token Sep 2, 2024
@eyurtsev eyurtsev merged commit 62e648a into main Sep 2, 2024
@eyurtsev eyurtsev deleted the wfh/support_correction branch September 2, 2024 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"correction" field isn't passed from the "token_feedback" endpoint to the Langsmith "/feedback/tokens/" API

2 participants