Keep frame pointers by default with -O for some targets #4889
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kinke
force-pushed
the
drt_exceptions
branch
2 times, most recently
from
6f501af to
fe30562
Compare
kinke
changed the title
kinke
commented
Mar 22, 2025
| // Keep frame pointers by default with enabled optimizations? | ||
| // The logic is very loosely based on clang's | ||
| // `useFramePointerForTargetByDefault()`, as well as backtrace test results for | ||
| // druntime-test-exceptions-release. |
There was a problem hiding this comment.
Primarily to fix (druntime) backtraces with optimized code for those targets, incl. prebuilt release druntime/Phobos. Fixes ldc-developers#4594 and ldc-developers#4694.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Primarily to fix (druntime) backtraces with optimized code for those targets, incl. prebuilt release druntime/Phobos.
Fixes #4594 and #4694.