KEMBAR78
[libc++] fix `array<T, 0>` under `USE_WRAP_ITER` by strega-nil · Pull Request #101156 · llvm/llvm-project · GitHub
Skip to content

[libc++] fix array<T, 0> under USE_WRAP_ITER #101156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 30, 2024
Merged

[libc++] fix array<T, 0> under USE_WRAP_ITER #101156

merged 2 commits into from
Jul 30, 2024

Conversation

@strega-nil
Copy link
Contributor

array<T, 0>::iterator was always a pointer even when _LIBCXX_ABI_USE_WRAP_ITER_IN_STD_ARRAY was defined. This patch fixes that minor bug.

Discovered as part of #100603.

@strega-nil
[libc++] fix array<T, 0> under USE_WRAP_ITER
5593ed2 
`array<T, 0>::iterator` was always a pointer even when
`_LIBCXX_ABI_USE_WRAP_ITER_IN_STD_ARRAY` was defined. This patch fixes
that minor bug.

Discovered as part of [llvm#100603][].

[llvm#100603]: llvm#100603
@strega-nil strega-nil requested a review from a team as a code owner July 30, 2024 09:30
Zingam
Zingam reviewed Jul 30, 2024
View reviewed changes
@strega-nil
drive-by: replace typedef with using
b558a7e 
all throughout the `array` header.
@cor3ntin cor3ntin added the libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi. label Jul 30, 2024
ldionne
ldionne approved these changes Jul 30, 2024
View reviewed changes
Copy link
Member

@ldionne ldionne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that the reason we were introducing new broken test code without noticing?

Either way, thanks for fixing.

@strega-nil
Copy link
Contributor Author

@ldionne exactly :)

@strega-nil strega-nil merged commit d067062 into llvm:main Jul 30, 2024
@strega-nil strega-nil deleted the fix-array-iterator-wrapping branch July 30, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Zingam Zingam Zingam left review comments

@ldionne ldionne ldionne approved these changes

Assignees

No one assigned

Labels

libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@strega-nil @ldionne @Zingam @cor3ntin