[libc++] Avoid including <__config> directly in the test suite #106080
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llvmbot
added
the
libc++
|
@llvm/pr-subscribers-libcxx Author: Louis Dionne (ldionne) ChangesFixes #105878 Full diff: https://github.com/llvm/llvm-project/pull/106080.diff 1 Files Affected:
diff --git a/libcxx/test/support/fp_compare.h b/libcxx/test/support/fp_compare.h
index 3088a211dadc3b..63f174e0a29d87 100644
--- a/libcxx/test/support/fp_compare.h
+++ b/libcxx/test/support/fp_compare.h
@@ -9,16 +9,17 @@
#ifndef SUPPORT_FP_COMPARE_H
#define SUPPORT_FP_COMPARE_H
-#include <cmath> // for std::abs
#include <algorithm> // for std::max
#include <cassert>
-#include <__config>
+#include <cmath> // for std::abs
+
+#include "test_macros.h"
// See https://www.boost.org/doc/libs/1_70_0/libs/test/doc/html/boost_test/testing_tools/extended_comparison/floating_point/floating_points_comparison_theory.html
template <typename T>
bool fptest_close(T val, T expected, T eps) {
- _LIBCPP_CONSTEXPR T zero = T(0);
+ TEST_CONSTEXPR T zero = T(0);
assert(eps >= zero);
// Handle the zero cases
|
You can test this locally with the following command:git-clang-format --diff 1c48c9cc43dbbbd1751e15d199b4d7d4fc52d828 e63394b940b374ee719d7c04e3fb1500a097efe2 --extensions h -- libcxx/test/support/fp_compare.hView the diff from clang-format here.diff --git a/libcxx/test/support/fp_compare.h b/libcxx/test/support/fp_compare.h
index 63f174e0a2..237ee50d1f 100644
--- a/libcxx/test/support/fp_compare.h
+++ b/libcxx/test/support/fp_compare.h
@@ -11,7 +11,7 @@
#include <algorithm> // for std::max
#include <cassert>
-#include <cmath> // for std::abs
+#include <cmath> // for std::abs
#include "test_macros.h"
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #105878