always set default value instead of .env #373
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have a problem with this, but dunno if its related. So in my case, .env.staging and .env.production works, but whenever I try to use .env or .env.development I can't read from it |
|
@mushinz Your problem maybe envConfigFiles key mismatch build variant as I see #381. This key is assembled to gradle task name and this library use this naming rule to detect which your build environment used. Thus, gradle task throw error when task name doesn't depend on build variant. This PR avoid to do when you set some env path as default. |
luancurti
approved these changes
Mar 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #327
This is one solution using defalutEnvFile to avoid mismatching env setting by not included build variant string if the other task about build task calling dotenv.gradle. check #327.