Exclude cancelled requests from in-progress lists #5016
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The Sonarcloud objections appear to be in code unrelated to anything I changed. |
uhoreg
reviewed
Sep 22, 2025
uhoreg
approved these changes
Sep 23, 2025
andybalaam
force-pushed
the
andybalaam/filter-cancelled-verification-requests
branch
from
b9d24ba to
fca9315
Compare
Fixes element-hq/element-web#29882 When we ask for the in-progress verification requests, exclude requests that have been cancelled. This means that we don't erroneously tell the user that the new request they are about to create has been cancelled.
andybalaam
force-pushed
the
andybalaam/filter-cancelled-verification-requests
branch
from
fca9315 to
e136116
Compare
andybalaam
deleted the
andybalaam/filter-cancelled-verification-requests
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes element-hq/element-web#29882
When we ask for the in-progress verification requests, exclude requests that have been cancelled. This means that we don't erroneously tell the user that the new request they are about to create has been cancelled.
A higher-level test for this bug is introduced in element-hq/element-web#30835