KEMBAR78
Improve touch events example code by mohd-akram · Pull Request #41399 · mdn/content · GitHub
Skip to content

Improve touch events example code #41399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 21, 2025
Merged

Improve touch events example code #41399

merged 3 commits into from
Oct 21, 2025
+154 −203

Conversation

mohd-akram
Copy link
Contributor

Description

Use a better data structure and simplify code.

Motivation

The code is unclear.

Additional details

Related issues and pull requests

@mohd-akram mohd-akram requested a review from a team as a code owner October 5, 2025 16:38
@mohd-akram mohd-akram requested review from wbamberg and removed request for a team October 5, 2025 16:38
@github-actions github-actions bot added Content:WebAPI Web API docs size/m [PR only] 51-500 LoC changed labels Oct 5, 2025
@Josh-Cena
Copy link
Member

Thanks, related: #34909

@github-actions
Copy link
Contributor

github-actions bot commented Oct 21, 2025 •
edited
Loading

Preview URLs

Flaws (2)

Note! 3 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/API/TouchEvent
Title: TouchEvent
Flaw count: 2

  • macros:
    • Can't resolve /en-US/docs/Web/API/TouchEvent/rotation
    • Can't resolve /en-US/docs/Web/API/TouchEvent/scale

(comment last updated: 2025-10-21 22:17:11)

Josh-Cena
Josh-Cena approved these changes Oct 21, 2025
View reviewed changes
Copy link
Member

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I ported over some more code from the pointer events page to make them consistent.

@Josh-Cena Josh-Cena merged commit 3676181 into mdn:main Oct 21, 2025
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Josh-Cena Josh-Cena Josh-Cena approved these changes

@wbamberg wbamberg Awaiting requested review from wbamberg wbamberg is a code owner automatically assigned from mdn/yari-content-web-api

Assignees

No one assigned

Labels

Content:WebAPI Web API docs size/m [PR only] 51-500 LoC changed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mohd-akram @Josh-Cena