LoRA typo fix + bias=True #1881
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 22, 2024 09:57
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchtune/1881
Note: Links to docs will display an error until the docs builds have been completed. ❌ 5 New Failures, 5 Cancelled JobsAs of commit aba63fe with merge base ca37c59 ( NEW FAILURES - The following jobs have failed:
CANCELLED JOBS - The following jobs were cancelled. Please retry:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
felipemello1
commented
Oct 22, 2024
Comment on lines
+12
to
+30
| from torchtune.models.clip._position_embeddings import ( | ||
| TiledTokenPositionalEmbedding, | ||
| TilePositionalEmbedding, | ||
| TokenPositionalEmbedding, | ||
| ) | ||
|
|
||
| from torchtune.modules import ( | ||
| TransformerSelfAttentionLayer, | ||
| FeedForward, | ||
| Fp32LayerNorm, | ||
| MultiHeadAttention, | ||
| TanhGate, | ||
| FeedForward, | ||
| Fp32LayerNorm | ||
| TransformerSelfAttentionLayer, | ||
| ) | ||
|
|
||
| from torchtune.modules.common_utils import reparametrize_as_dtype_state_dict_post_hook | ||
|
|
||
| from torchtune.modules.peft import DoRALinear, LORA_ATTN_MODULES, LoRALinear | ||
|
|
||
| from torchtune.modules.vision_transformer import CLSProjection, VisionTransformer |
There was a problem hiding this comment.
precommit hook reordering
Comment on lines
+506
to
+521
| in_dim=in_dim, | ||
| out_dim=hidden_dim, | ||
| rank=lora_rank, | ||
| alpha=lora_alpha, | ||
| dropout=lora_dropout, | ||
| quantize_base=quantize_base, | ||
| use_bias=True, | ||
| ) | ||
| down_proj = adapter_cls( | ||
| in_dim=hidden_dim, | ||
| out_dim=dim, | ||
| out_dim=out_dim, | ||
| rank=lora_rank, | ||
| alpha=lora_alpha, | ||
| dropout=lora_dropout, | ||
| quantize_base=quantize_base, | ||
| use_bias=True, |
pbontrager
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
What is the purpose of this PR? Is it to
Test plan