KEMBAR78
Temporarily disable building Python 3.13 version of torchtune by joecummings · Pull Request #1896 · meta-pytorch/torchtune · GitHub
Skip to content

Conversation

joecummings
Copy link
Member

Context

What is the purpose of this PR? Is it to

  • add a new feature
  • fix a bug
  • update tests and/or documentation
  • other (please add here)

At the moment, PyArrow does not have a build for Python 3.13. PyArrow is a dependency of Hugging Face Datasets, which torchtune depends upon. Since PyArrow does not have this build, the nightly build of torchtune on Python 3.13 fails. Since it appears that PyArrow's support for Python 3.13 is imminent, we are choosing to temporarily disable Python 3.13 builds until PyArrow v18 comes out on PyPI.

cc @atalman

Changelog

What are the changes made in this PR?

  • Add filter to our build script

Test plan

Please make sure to do each of the following if applicable to your PR. If you're unsure about any one of these just ask and we will happily help. We also have a contributing page for some guidance on contributing.

  • run pre-commit hooks and linters (make sure you've first installed via pre-commit install)
  • add unit tests for any new functionality
  • update docstrings for any new or updated methods or classes
  • run unit tests via pytest tests
  • run recipe tests via pytest tests -m integration_test
  • manually run any new or modified recipes with sufficient proof of correctness
  • include relevant commands and any other artifacts in this summary (pastes of loss curves, eval results, etc.)

@pytorch-bot
Copy link

pytorch-bot bot commented Oct 24, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchtune/1896

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit a8e96cd with merge base 2e5f647 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 24, 2024
Copy link
Contributor

@atalman atalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@joecummings joecummings merged commit e4d805c into meta-pytorch:main Oct 24, 2024
16 checks passed
@joecummings joecummings deleted the filter-python-build-version branch October 24, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants