KEMBAR78
Upgrade to OTel 1.35.0 and Zipkin dependencies by codefromthecrypt · Pull Request #536 · micrometer-metrics/tracing · GitHub
Skip to content

Conversation

@codefromthecrypt
Copy link
Contributor

@codefromthecrypt codefromthecrypt commented Jan 15, 2024

This updates to latest otel 0.35.0 which lets tests use latest zipkin-reporter 3.x. There are no changes to main code except some doc fuzz caused by running the gradle build.

@codefromthecrypt
Copy link
Contributor Author

all the things that need to merge are merged in otel now, so we can start the road to clean deps as soon as otel-java 1.35 is out. I'll help with this and redo this PR once that happens. cc @shakuzen

@codefromthecrypt
Copy link
Contributor Author

@codefromthecrypt codefromthecrypt changed the title Adds migration notes for otel-java 1.35.0 deps: updates tests to use latest otel and zipkin-reporter Feb 10, 2024
@codefromthecrypt
Copy link
Contributor Author

ok ready to roll I think!

@codefromthecrypt
Copy link
Contributor Author

ps since you all are the tracing team, maybe help andy take a look at this spring-projects/spring-boot#39049

@codefromthecrypt
Copy link
Contributor Author

actually, this is useless until spring boot updates, as it is doing the auto-wiring. We need to watch and update after spring-projects/spring-boot#39049

Bump io.opentelemetry:opentelemetry-bom from 1.34.1 to 1.35.0
Bump io.opentelemetry:opentelemetry-bom-alpha from 1.34.1-alpha to 1.35.0-alpha
Bump io.zipkin.reporter2:zipkin-reporter-bom from 2.17.2 to 3.2.1
Bump io.zipkin.aws:brave-propagation-aws from 0.24.0 to 1.2.3

Signed-off-by: Adrian Cole <adrian@tetrate.io>
@jonatan-ivanov jonatan-ivanov added dependency-upgrade A dependency upgrade java Pull requests that update Java code labels Feb 12, 2024
@jonatan-ivanov jonatan-ivanov added this to the 1.3.0-M1 milestone Feb 12, 2024
@jonatan-ivanov jonatan-ivanov changed the title deps: updates tests to use latest otel and zipkin-reporter Upgrade to OTel 1.35.0 and Zipkin dependencies Feb 12, 2024
@jonatan-ivanov
Copy link
Member

Since some of the changes here are needed to Upgrade to OTel 1.35.0, I think we should merge this before doing the migration in Boot. OTel released 1.35.0-alpha so I upgraded it (ideally we should do both but OTel do not release them together) and also brave-propagation-aws to 1.2.3.

@jonatan-ivanov jonatan-ivanov merged commit ba54c99 into micrometer-metrics:main Feb 12, 2024
@codefromthecrypt codefromthecrypt deleted the upgrade-notes branch February 12, 2024 23:14
@codefromthecrypt
Copy link
Contributor Author

ok you know better than me. thanks!

@codefromthecrypt
Copy link
Contributor Author

fyi playground I used today which pulls things together openzipkin/brave-example#114

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependency-upgrade A dependency upgrade java Pull requests that update Java code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants