KEMBAR78
Test-related improvements by Youssef1313 · Pull Request #610 · microsoft/ApplicationInspector · GitHub
Skip to content

Conversation

@Youssef1313
Copy link
Member

@Youssef1313 Youssef1313 commented May 14, 2025

  • TrxReport and CodeCoverage extensions are already dependencies of MSTest metapackage. So, removed those unnecessary PackageReferences.
  • Using Combinatorial.MSTest to simplify some usages of DataRows (NOTE: it's mostly an adjusted copy of xunit.combinatorial done under the same license, MS-PL).
  • Fix analyzer warnings to use ThrowsExactly
  • Use TestMethodAttribute instead of DataTestMethodAttribute

@danfiedler-msft @gfs for review please.

FYI @Evangelink as parts of this PR is a follow-up to #603

@gfs
Copy link
Contributor

gfs commented May 21, 2025

/azp run

@gfs
Copy link
Contributor

gfs commented May 28, 2025

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@gfs
Copy link
Contributor

gfs commented May 29, 2025

SDL Sources failure expected on builds from fork.

@gfs gfs merged commit 30c2b5a into microsoft:main May 29, 2025
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants