Implement LWG-3677 Is a cv-qualified pair specially handled in uses-allocator construction?
#3396
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also `_STD`-qualify all _Ugly names in `<scoped_allocator>` and `<xpolymorphic_allocator.h>`. Also change try-catch block in `<xpolymorphic_allocator.h>` to scoped guard.
StephanTLavavej
approved these changes
Feb 11, 2023
This comment was marked as resolved.
This comment was marked as resolved.
This was referenced Feb 12, 2023
|
I am a greedy kitty who is speculatively mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
CaseyCarter
approved these changes
Feb 25, 2023
|
Thanks for implementing this LWG issue resolution, getting that chart line closer to zero! 📉 😸 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3220.
Driven-by changes:
_STD-qualifies all _Ugly function calls in<scoped_allocator>and<xpolymorphic_allocator.h>(and some in<xmemory>). Towards STL: We should _STD qualify _Ugly function calls to avoid ADL #140.<xpolymorphic_allocator.h>to a scoped guard. Towards<vector>, etc.: avoid_RERAISEin favor of usual scope guards #2307.