KEMBAR78
`<cmath>`: Enable Clang FP comparison intrinsics for heterogeneous FP comparison function overloads by frederick-vs-ja · Pull Request #4648 · microsoft/STL · GitHub
Skip to content

Conversation

@frederick-vs-ja
Copy link
Contributor

Follows-up #4612. Furtherly works towards #4609.

Also

  • tests all heterogeneous FP comparison function overloads, and
  • tests conversions from integers to double in FP comparison functions, and
  • cites DevCom-10294165 instead of GH-519 (which is now closed) in TRANSITION comments, with the word "major" dropped to avoid line breaking.

@frederick-vs-ja frederick-vs-ja requested a review from a team as a code owner May 2, 2024 17:50
@StephanTLavavej StephanTLavavej added the performance Must go faster label May 7, 2024
@StephanTLavavej StephanTLavavej self-assigned this May 7, 2024
@StephanTLavavej
Copy link
Member

Thanks! I pushed a conflict-free merge with main and a comment typo fix.

@StephanTLavavej StephanTLavavej removed their assignment Jun 24, 2024
@StephanTLavavej StephanTLavavej self-assigned this Jun 26, 2024
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 243ac89 into microsoft:main Jun 27, 2024
@StephanTLavavej
Copy link
Member

Thanks for improving <cmath> performance even more! 🚀 🧮 ⚡

@frederick-vs-ja frederick-vs-ja deleted the builtin-fp-cmp branch June 27, 2024 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

performance Must go faster

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants