KEMBAR78
Re-skip a condvar test by StephanTLavavej · Pull Request #4732 · microsoft/STL · GitHub
Skip to content

Re-skip a condvar test #4732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 18, 2024
Merged

Re-skip a condvar test #4732

merged 2 commits into from
Jun 18, 2024

Conversation

@StephanTLavavej
Copy link
Member

@StephanTLavavej StephanTLavavej commented Jun 18, 2024 •
edited
Loading

After merging #4721, two CI runs sporadically failed with:

Assertion failed: test1 == 0, file D:\a\_work\1\s\llvm-project\libcxx\test\std\thread\thread.condition\thread.condition.condvar\notify_all.pass.cpp, line 35

Assertion failed: test2 == 0, file D:\a\_work\1\s\llvm-project\libcxx\test\std\thread\thread.condition\thread.condition.condvar\notify_all.pass.cpp, line 45

This test is bogus, so I've reported llvm/llvm-project#95944 upstream. It appears to be the only affected test.

@StephanTLavavej StephanTLavavej added high priority Important! test Related to test code labels Jun 18, 2024
@StephanTLavavej StephanTLavavej requested a review from a team as a code owner June 18, 2024 07:02
@StephanTLavavej StephanTLavavej changed the title Re-skip condvar tests Re-skip a condvar test Jun 18, 2024
@StephanTLavavej StephanTLavavej mentioned this pull request Jun 18, 2024
Open
@StephanTLavavej StephanTLavavej merged commit 406d06f into microsoft:main Jun 18, 2024
@StephanTLavavej StephanTLavavej deleted the reskip-condvar branch June 18, 2024 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

high priority Important! test Related to test code

Projects

STL Code Reviews
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@StephanTLavavej