KEMBAR78
Implement LWG-4106 `basic_format_args` should not be default-constructible by frederick-vs-ja · Pull Request #4757 · microsoft/STL · GitHub
Skip to content

Conversation

frederick-vs-ja
Copy link
Contributor

@frederick-vs-ja frederick-vs-ja commented Jun 30, 2024

See LWG-4106 and WG21-P3341R0.

Blocked libcxx tests

  • std/utilities/format/format.arguments/format.args/ctor.pass.cpp
  • std/utilities/format/format.arguments/format.args/get.pass.cpp

@frederick-vs-ja frederick-vs-ja requested a review from a team as a code owner June 30, 2024 15:34
@StephanTLavavej StephanTLavavej added LWG Library Working Group issue format C++20/23 format labels Jun 30, 2024
@StephanTLavavej StephanTLavavej self-assigned this Jun 30, 2024
@StephanTLavavej
Copy link
Member

Perfection! 🐈

@StephanTLavavej StephanTLavavej removed their assignment Jul 3, 2024
@StephanTLavavej StephanTLavavej self-assigned this Jul 4, 2024
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej
Copy link
Member

I've pushed a merge with main to resolve a trivial adjacent-add conflict with #4758 in tests/libcxx/expected_results.txt.

@StephanTLavavej StephanTLavavej merged commit 53f1faf into microsoft:main Jul 5, 2024
@StephanTLavavej
Copy link
Member

Thanks for yet another speedy resolution! 🚀 🚀 🚀

@frederick-vs-ja frederick-vs-ja deleted the lwg-4106 branch July 5, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

format C++20/23 format LWG Library Working Group issue

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants