KEMBAR78
`move_iterator` visualizer should use `_Current` by fsb4000 · Pull Request #4836 · microsoft/STL · GitHub
Skip to content

move_iterator visualizer should use _Current #4836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 8, 2024
Merged

move_iterator visualizer should use _Current #4836

merged 1 commit into from
Aug 8, 2024

Conversation

@fsb4000
Copy link
Contributor

@fsb4000 fsb4000 commented Jul 12, 2024

Fixes #4829

Test code:

#include <iterator>
#include <string>
#include <vector>

int main()
{
    std::vector<std::string> v{ "This", "_", "is", "_", "an", "_", "example" };
    auto begin = std::make_move_iterator(v.begin());
    return 0;
}

Result:
изображение

@fsb4000 fsb4000 requested a review from a team as a code owner July 12, 2024 16:38
@StephanTLavavej StephanTLavavej added bug Something isn't working visualizer How the VS debugger displays STL types labels Jul 17, 2024
@StephanTLavavej StephanTLavavej self-assigned this Jul 17, 2024
@StephanTLavavej StephanTLavavej changed the title move_iterator visualizer should use _Current move_iterator visualizer should use _Current Jul 17, 2024
@StephanTLavavej StephanTLavavej removed their assignment Jul 19, 2024
@StephanTLavavej StephanTLavavej mentioned this pull request Jul 19, 2024
Open
@StephanTLavavej StephanTLavavej self-assigned this Aug 6, 2024
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej mentioned this pull request Aug 7, 2024
Closed
@StephanTLavavej StephanTLavavej merged commit 85a4a5f into microsoft:main Aug 8, 2024
@StephanTLavavej
Copy link
Member

Oops, I thanked you in the commit message itself, instead of a comment. First time I've ever made that mistake 🤪 ⛔ 🧠

@fsb4000 fsb4000 deleted the fix4829 branch August 10, 2024 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

Assignees

@StephanTLavavej StephanTLavavej

Labels

bug Something isn't working visualizer How the VS debugger displays STL types

Projects

STL Code Reviews
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

STL.natvis: move_iterator visualizer should use _Current, not current

2 participants

@fsb4000 @StephanTLavavej