KEMBAR78
`<spanstream>`: Use `static_cast` to `std::span` to avoid ill-formed constructs by euvre · Pull Request #4938 · microsoft/STL · GitHub
Skip to content

<spanstream>: Use static_cast to std::span to avoid ill-formed constructs #4938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Sep 9, 2024
Merged

<spanstream>: Use static_cast to std::span to avoid ill-formed constructs #4938

merged 13 commits into from
Sep 9, 2024

Conversation

@euvre
Copy link
Contributor

@euvre euvre commented Sep 5, 2024

fix #4879

@euvre euvre requested a review from a team as a code owner September 5, 2024 09:03
frederick-vs-ja
frederick-vs-ja suggested changes Sep 5, 2024
View reviewed changes
@euvre
Copy link
Contributor Author

euvre commented Sep 5, 2024

@microsoft-github-policy-service agree

@StephanTLavavej StephanTLavavej added bug Something isn't working ranges C++20/23 ranges labels Sep 5, 2024
@StephanTLavavej StephanTLavavej self-assigned this Sep 5, 2024
CaseyCarter
CaseyCarter suggested changes Sep 5, 2024
View reviewed changes
@StephanTLavavej StephanTLavavej removed their assignment Sep 5, 2024
@StephanTLavavej StephanTLavavej changed the title <spanstream>: Use static_cast to std::span to avoid ill-formed constructs <spanstream>: Use static_cast to std::span to avoid ill-formed constructs Sep 7, 2024
StephanTLavavej
StephanTLavavej reviewed Sep 7, 2024
View reviewed changes
@StephanTLavavej StephanTLavavej removed their assignment Sep 7, 2024
@StephanTLavavej
Copy link
Member

Thanks, looks good! I pushed changes for the issues I found.

@CaseyCarter CaseyCarter removed their assignment Sep 8, 2024
@StephanTLavavej StephanTLavavej self-assigned this Sep 9, 2024
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 3da77eb into microsoft:main Sep 9, 2024
39 checks passed
@StephanTLavavej
Copy link
Member

Thanks for fixing this bug in a new feature and thoroughly testing it! 🐞 🛠️ ✅

@euvre euvre deleted the issue-004879 branch September 10, 2024 06:37
@StephanTLavavej StephanTLavavej mentioned this pull request Sep 11, 2024
Open
@Morddin Morddin mentioned this pull request Feb 23, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StephanTLavavej StephanTLavavej StephanTLavavej approved these changes

+2 more reviewers

@frederick-vs-ja frederick-vs-ja frederick-vs-ja requested changes

@CaseyCarter CaseyCarter CaseyCarter approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@StephanTLavavej StephanTLavavej

Labels

bug Something isn't working ranges C++20/23 ranges

Projects

STL Code Reviews
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

<spanstream>: The span constructed by basic_ispanstream's range constructor may be ill-formed

4 participants

@euvre @StephanTLavavej @CaseyCarter @frederick-vs-ja