<deque>: Add missed masking of _First_used_block_idx in deque::shrink_to_fit to correctly end the loop
#4955
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frederick-vs-ja
force-pushed
the
deque-missed-mask
branch
from
8a5d875 to
5035178
Compare
CaseyCarter
suggested changes
Sep 13, 2024
CaseyCarter
approved these changes
Sep 14, 2024
StephanTLavavej
approved these changes
Sep 16, 2024
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
|
Thanks for fixing this runtime correctness regression in the STL's best and universally adored data structure! 🐞 🛠️ 😹 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4954.
In #4091,
_First_used_block_idxwas incorrectly unmasked. In some problematic cases,_First_used_block_idxcan become larger than_Mask, which could render the loop infinite.