KEMBAR78
Fix floating `minmax` performance by AlexGuteniev · Pull Request #5016 · microsoft/STL · GitHub
Skip to content

Conversation

@AlexGuteniev
Copy link
Contributor

Work around DevCom-10767462

Looks fragile (how can we be sure that the compiler won't misplace another vzeroupper too?) but seems to work.

Alternative to #5010

@AlexGuteniev AlexGuteniev requested a review from a team as a code owner October 14, 2024 05:04
@StephanTLavavej StephanTLavavej changed the title Fix floating minmax performance Fix floating minmax performance Oct 14, 2024
@StephanTLavavej StephanTLavavej added the performance Must go faster label Oct 14, 2024
@StephanTLavavej StephanTLavavej self-assigned this Oct 14, 2024
@StephanTLavavej
Copy link
Member

Thanks for figuring out this problem and how to work around it! I pushed a conflict-free merge with main, and an ARM64EC fix.

@StephanTLavavej StephanTLavavej removed their assignment Oct 17, 2024
@StephanTLavavej StephanTLavavej self-assigned this Oct 21, 2024
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 3532569 into microsoft:main Oct 21, 2024
39 checks passed
@StephanTLavavej
Copy link
Member

🩹 😻 🎉

@AlexGuteniev AlexGuteniev deleted the perf-floats-away branch October 22, 2024 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

performance Must go faster

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants