KEMBAR78
`requires` for `chrono::parse` and comparison category detection by frederick-vs-ja · Pull Request #5044 · microsoft/STL · GitHub
Skip to content

Conversation

frederick-vs-ja
Copy link
Contributor

Towards #602.

Drive-by: Simply sub_match by reusing _Get_comparison_category_t.

@frederick-vs-ja frederick-vs-ja requested a review from a team as a code owner October 27, 2024 04:48
Drive-by: Simply `sub_match` by reusing `_Get_comparison_category_t`.
@StephanTLavavej StephanTLavavej added the enhancement Something can be improved label Oct 27, 2024
Copy link
Contributor

@CaseyCarter CaseyCarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One typo that I'll fix.

@StephanTLavavej StephanTLavavej self-assigned this Oct 27, 2024
@StephanTLavavej

This comment was marked as resolved.

1 similar comment
@StephanTLavavej
Copy link
Member

/azp run STL-CI

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@StephanTLavavej StephanTLavavej removed their assignment Oct 29, 2024
@StephanTLavavej StephanTLavavej self-assigned this Oct 29, 2024
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 30c9391 into microsoft:main Oct 30, 2024
39 checks passed
@StephanTLavavej
Copy link
Member

Thanks for finding even more SFINAE to eradicate! 🧹 🪄 ⚙️

@frederick-vs-ja frederick-vs-ja deleted the requires-misc-2 branch October 30, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Something can be improved

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants