KEMBAR78
Don't use `__restrict__` for CUDA by StephanTLavavej · Pull Request #5097 · microsoft/STL · GitHub
Skip to content

Don't use __restrict__ for CUDA #5097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 19, 2024
Merged

Don't use __restrict__ for CUDA #5097

merged 2 commits into from
Nov 19, 2024

Conversation

@StephanTLavavej
Copy link
Member

#5079 was a nice try, but it doesn't work. We need to revert this before 17.13 Preview 3 branches for release.

It broke NVIDIA's Cutlass again. @CaseyCarter observed:

In both the old and new preprocessed repros, our _RESTRICTs in the declaration of _Adjacent_difference_no_overlap are being expanded to plain restrict. If I had to guess, I'd say that CUDA is replacing __restrict__ with restrict under the expectation that __restrict__ is only used in C mode.

Fixes VSO-2295101 / AB#2295101 again.

@StephanTLavavej StephanTLavavej added bug Something isn't working high priority Important! labels Nov 18, 2024
@StephanTLavavej StephanTLavavej requested a review from a team as a code owner November 18, 2024 20:24
@StephanTLavavej StephanTLavavej mentioned this pull request Nov 18, 2024
Open
@CaseyCarter CaseyCarter removed their assignment Nov 18, 2024
@StephanTLavavej StephanTLavavej self-assigned this Nov 19, 2024
@StephanTLavavej
Copy link
Member Author

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 99ef0d0 into microsoft:main Nov 19, 2024
39 checks passed
@StephanTLavavej StephanTLavavej deleted the revert-restrict branch November 19, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@CaseyCarter CaseyCarter CaseyCarter approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@StephanTLavavej StephanTLavavej

Labels

bug Something isn't working high priority Important!

Projects

STL Code Reviews
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@StephanTLavavej @CaseyCarter