KEMBAR78
Implement LWG-3886 Monad mo' problems (in `optional` and `expected`) by frederick-vs-ja · Pull Request #5232 · microsoft/STL · GitHub
Skip to content

Conversation

@frederick-vs-ja
Copy link
Contributor

@frederick-vs-ja frederick-vs-ja commented Jan 12, 2025

Also speculatively implement LWG-3424 for expected to avoid volatile-qualified return types, and complete the speculative implementation for optional.

Some parts of the resolution is not meaningful yet and not tested due to LWG-3891.

Fixes #5119.

Also speculatively implement LWG-3424 for `expected`.
@frederick-vs-ja frederick-vs-ja requested a review from a team as a code owner January 12, 2025 23:19
@StephanTLavavej StephanTLavavej added the LWG Library Working Group issue label Jan 12, 2025
@StephanTLavavej StephanTLavavej self-assigned this Jan 12, 2025
@StephanTLavavej

This comment was marked as resolved.

@frederick-vs-ja

This comment was marked as resolved.

@StephanTLavavej StephanTLavavej removed their assignment Jan 13, 2025
@StephanTLavavej
Copy link
Member

Thanks! 😻 I noticed that LWG-3424 wasn't completely implemented for optional. It turns out this went back to #674 on 2020-04-03 which implemented the original proposed resolution. @CaseyCarter improved the LWG issue's proposed resolution on 2023-02-09, which I have now implemented 🐱

@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 8578314 into microsoft:main Jan 14, 2025
39 checks passed
@StephanTLavavej
Copy link
Member

📈 💚 😻

@frederick-vs-ja frederick-vs-ja deleted the lwg-3886 branch January 14, 2025 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

LWG Library Working Group issue

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

LWG-3886 Monad mo' problems (in optional and expected)

2 participants