KEMBAR78
Update _MSVC_STL_UPDATE to March 2025 by runzh-crypto · Pull Request #5323 · microsoft/STL · GitHub
Skip to content

Conversation

runzh-crypto
Copy link
Contributor

resolves #5320

@runzh-crypto runzh-crypto requested a review from a team as a code owner March 5, 2025 06:52
@github-project-automation github-project-automation bot moved this to Initial Review in STL Code Reviews Mar 5, 2025
@StephanTLavavej StephanTLavavej added the enhancement Something can be improved label Mar 5, 2025
@StephanTLavavej StephanTLavavej moved this from Initial Review to Ready To Merge in STL Code Reviews Mar 5, 2025
@StephanTLavavej StephanTLavavej changed the title Update _MSVC_STL_UPDATE to March 2025 #5320 Update _MSVC_STL_UPDATE to March 2025 Mar 5, 2025
@StephanTLavavej
Copy link
Member

Thanks, looks great! I've edited your PR title to remove the issue number (as it would distract from the PR number when merged). The PR description mentioning "resolves #nnnn" is perfect and sufficient.

We merge PRs simultaneously to our GitHub and MS-internal repos in a semi-manual process, batched up to save time. Your PR will be part of the next batch, likely next week (depending on how busy I am). I'll post comments here as I prepare your PR for merging.

@StephanTLavavej StephanTLavavej self-assigned this Mar 12, 2025
@StephanTLavavej StephanTLavavej moved this from Ready To Merge to Merging in STL Code Reviews Mar 12, 2025
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 18cdebd into microsoft:main Mar 13, 2025
39 checks passed
@github-project-automation github-project-automation bot moved this from Merging to Done in STL Code Reviews Mar 13, 2025
@StephanTLavavej
Copy link
Member

Thanks for updating this version macro, and congratulations on your first microsoft/STL commit! 😻 🎉 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Something can be improved

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

<yvals_core.h>: Update _MSVC_STL_UPDATE to March 2025

3 participants