KEMBAR78
`<xutility>`: Adjust inheritance detection for `enable_view` by frederick-vs-ja · Pull Request #5369 · microsoft/STL · GitHub
Skip to content

Conversation

@frederick-vs-ja
Copy link
Contributor

@frederick-vs-ja frederick-vs-ja commented Mar 27, 2025

Per [range.view]/6, a view_interface isn't a base class of itself, so enable_view should report false. Also, current implementation strategy handles const but not volatile, IIUC cv-qualifiers should be consistent handled.

Coverage for (const) volatile types are added.

The original issue was reported as LLVM-132577, and the PR fixing it (LLVM-132582) was recently accepted for libc++.

Drive-by: Change the implement strategy of operator<=> for optional to be more consistent with the Standardese ([optional.syn]), as the old _Derived_from_specialization_of doesn't seem reusable.

@frederick-vs-ja frederick-vs-ja requested a review from a team as a code owner March 27, 2025 09:14
@github-project-automation github-project-automation bot moved this to Initial Review in STL Code Reviews Mar 27, 2025
@StephanTLavavej StephanTLavavej added bug Something isn't working ranges C++20/23 ranges labels Mar 27, 2025
@StephanTLavavej StephanTLavavej self-assigned this Mar 27, 2025
@StephanTLavavej StephanTLavavej removed their assignment Mar 31, 2025
@StephanTLavavej StephanTLavavej moved this from Initial Review to Ready To Merge in STL Code Reviews Mar 31, 2025
@StephanTLavavej StephanTLavavej moved this from Ready To Merge to Merging in STL Code Reviews Apr 9, 2025
@StephanTLavavej StephanTLavavej self-assigned this Apr 9, 2025
@StephanTLavavej
Copy link
Member

I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed.

@StephanTLavavej StephanTLavavej merged commit 9699391 into microsoft:main Apr 10, 2025
39 checks passed
@github-project-automation github-project-automation bot moved this from Merging to Done in STL Code Reviews Apr 10, 2025
@StephanTLavavej
Copy link
Member

🐞 🛠️ 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working ranges C++20/23 ranges

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants