<regex>: Do not reset matched capture groups in POSIX regexes
#5377
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephanTLavavej
added
bug
StephanTLavavej
approved these changes
Apr 3, 2025
|
Thanks! 😻 I added some test coverage, and I'm finally starting to understand how nested capture groups work 💡 |
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
|
Resolved adjacent-add conflicts in |
StephanTLavavej
approved these changes
Apr 10, 2025
🐱 😸 😻 |
muellerj2
deleted the
regex-do-not-reset-capture-groups-for-posix-regexes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #5365. Fixes the behavior for POSIX regexes: Section 9.3.6 says that backreferences always refer to the last matched string if a capture group/subexpression has been matched more than once, so captures should not be cleared during matching at all.