-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Add std::fill and std::fill_n benchmarks
#5400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add std::fill and std::fill_n benchmarks
#5400
Conversation
|
Thanks! 😸 I pushed significant changes - please meow if you have concerns. |
|
nah, lgtm. I don't really like pulling the allocators out into a template parameter, as I don't think it's worth multiplying the test matrix for them (although having some benchmarks use one and some the other probably was bad). |
If there's little difference in performance between allocators, I'd just use the worse one ( |
std::fill and std::fill_n benchmarks
|
Sounds good to me since I saw no perf difference. I'll validate and push. |
|
lgtm |
|
I'm mirroring this to the MSVC-internal repo - please notify me if any further changes are pushed. |
|
Thanks for filling out our benchmark directory! ⏱️ 📈 😹 |
I wrote these benchmarks while fixing some issues with memset loop recognition in the compiler, but I think they are more broadly useful.